feat: add node delete and update command #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…node-delete Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # src/commands/node.mjs
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
E2E Node PEM Stop Tests Coverage Report12 tests ±0 12 ✅ ±0 2m 31s ⏱️ -7s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Node Update Tests Coverage Report9 tests 6 ✅ 2m 44s ⏱️ Results for commit f61c549. ♻️ This comment has been updated with latest results. |
E2E Node PFX Kill Tests Coverage Report12 tests ±0 12 ✅ ±0 2m 56s ⏱️ +6s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Relay Tests Coverage Report1 files ±0 1 suites ±0 2m 54s ⏱️ +12s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Tests Coverage Report57 tests ±0 57 ✅ ±0 4m 23s ⏱️ +16s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Node Local Build Tests Coverage Report8 tests ±0 8 ✅ ±0 2m 44s ⏱️ -2s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Node Delete Tests Coverage Report9 tests 9 ✅ 5m 54s ⏱️ Results for commit f61c549. ♻️ This comment has been updated with latest results. |
E2E Node Add Tests Coverage Report20 tests ±0 20 ✅ +4 14m 43s ⏱️ + 3m 41s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Mirror Node Tests Coverage Report 1 files ±0 1 suites ±0 4m 8s ⏱️ +9s Results for commit f61c549. ± Comparison against base commit fa3a316. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 81.66% 78.24% -3.42%
==========================================
Files 35 36 +1
Lines 4429 4896 +467
Branches 671 690 +19
==========================================
+ Hits 3617 3831 +214
- Misses 812 1065 +253
|
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…node-delete Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…nd update podNames (#523) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
jeromy-cannon
approved these changes
Sep 3, 2024
swirlds-automation
added a commit
that referenced
this pull request
Sep 6, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-09-06) ### Features * add local build support for node add command ([#509](#509)) ([a7e778f](a7e778f)) * add node delete and update command ([#500](#500)) ([9f8549a](9f8549a)) * use k8s secrets to store node gossip and grpc tls keys and mount them ([#499](#499)) ([ede1842](ede1842)) ### Bug Fixes * added missing async/await where needed ([#551](#551)) ([d8e5032](d8e5032)) * improve types in JSDoc and fix typo in '/src/commands/account.mjs' ([#507](#507)) ([74c9e2c](74c9e2c)) * need to update agreement key together with signing key ([#539](#539)) ([f9b2e21](f9b2e21)) * removed the custom ip address logic and '@hashgraph/proto' ([#518](#518)) ([c81c76a](c81c76a))
|
🎉 This PR is included in version 0.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues
solo node deletesubcommand #474solo node updatesubcommand #473